Reject persisted failures during precompile
This commit is contained in:
+20
-7
@@ -1219,14 +1219,14 @@ void proactive_compile_queue_push(StringList& queue, String file_name)
|
||||
queue.push_back(file_name);
|
||||
}
|
||||
|
||||
bool proactive_compile_unit(Request& context, String file_name, bool& source_missing)
|
||||
bool proactive_compile_unit(Request& context, String file_name, bool& source_missing, bool force_compile = false)
|
||||
{
|
||||
bool failed = false;
|
||||
String wasm_path = compiler_unit_wasm_path(&context, file_name);
|
||||
if(compiler_unit_needs_recompile(&context, file_name, &source_missing))
|
||||
if(force_compile || compiler_unit_needs_recompile(&context, file_name, &source_missing))
|
||||
{
|
||||
printf("(i) proactive compile %s\n", file_name.c_str());
|
||||
auto su = get_shared_unit(&context, file_name);
|
||||
auto su = force_compile ? compiler_get_shared_unit_internal(&context, file_name, true) : get_shared_unit(&context, file_name);
|
||||
failed = !su || su->compiler_messages != "";
|
||||
if(su)
|
||||
wasm_path = su->wasm_name;
|
||||
@@ -1597,9 +1597,10 @@ PrecompileWorkerResult precompile_unit_range(Request& background_context, const
|
||||
{
|
||||
result.assigned++;
|
||||
bool source_missing = false;
|
||||
if(compiler_unit_needs_recompile(&background_context, files[i], &source_missing))
|
||||
bool needs_compile = compiler_unit_needs_recompile(&background_context, files[i], &source_missing, false, true, true);
|
||||
if(needs_compile)
|
||||
result.compiled++;
|
||||
if(proactive_compile_unit(background_context, files[i], source_missing))
|
||||
if(proactive_compile_unit(background_context, files[i], source_missing, needs_compile))
|
||||
result.failed++;
|
||||
}
|
||||
return(result);
|
||||
@@ -1653,7 +1654,16 @@ int precompile_unit_generation()
|
||||
auto files = compiler_scan_site_units(&background_context);
|
||||
compiler_set_known_units(&background_context, files);
|
||||
const char* jobs_env = getenv("UCE_PRECOMPILE_JOBS");
|
||||
u64 jobs = to_u64(jobs_env && jobs_env[0] != '\0' ? String(jobs_env) : server_state.config["PRECOMPILE_JOBS"], 2);
|
||||
String jobs_text = trim(jobs_env && jobs_env[0] != '\0' ? String(jobs_env) : server_state.config["PRECOMPILE_JOBS"]);
|
||||
u64 jobs = 2;
|
||||
if(jobs_text != "")
|
||||
{
|
||||
char* end = 0;
|
||||
errno = 0;
|
||||
long long parsed = strtoll(jobs_text.c_str(), &end, 10);
|
||||
if(end != jobs_text.c_str() && end && *end == '\0' && errno != ERANGE)
|
||||
jobs = parsed < 1 ? 1 : (u64)parsed;
|
||||
}
|
||||
jobs = std::max<u64>(1, std::min<u64>(jobs, std::min<u64>(files.size() == 0 ? 1 : files.size(), 16)));
|
||||
PrecompileWorkerResult total;
|
||||
bool worker_error = false;
|
||||
@@ -1717,10 +1727,13 @@ int precompile_unit_generation()
|
||||
if(total.assigned != files.size())
|
||||
worker_error = true;
|
||||
}
|
||||
printf("Precompiled unit generation %s with %llu job%s: %zu units, %llu compiled, %llu failed in %.3f s\n",
|
||||
if(worker_error)
|
||||
printf("(!) precompile worker or result reporting failed; candidate generation rejected\n");
|
||||
printf("Precompiled unit generation %s with %llu job%s: %zu units, %llu compiled, %llu failed, worker status %s in %.3f s\n",
|
||||
compiler_unit_bin_directory(&background_context).c_str(),
|
||||
(unsigned long long)jobs, jobs == 1 ? "" : "s", files.size(),
|
||||
(unsigned long long)total.compiled, (unsigned long long)total.failed,
|
||||
worker_error ? "failed" : "ok",
|
||||
time_precise() - started_at);
|
||||
return(total.failed == 0 && !worker_error ? 0 : 1);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user